Skip to content

fix: ars548: replace removed logger with nebula logger#321

Merged
mojomex merged 1 commit intotier4:mainfrom
TomohitoAndo:fix/missing-print-info
May 16, 2025
Merged

fix: ars548: replace removed logger with nebula logger#321
mojomex merged 1 commit intotier4:mainfrom
TomohitoAndo:fix/missing-print-info

Conversation

@TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented May 15, 2025

PR Type

  • Bug Fix

Related Links

Description

The Nebula node crashes with an undefined symbol error when calling the service for the ARS548, because it references a logging function that was previously removed.
The function was removed here.

[continental_ars548_ros_wrapper_node-34] /home/autoware/autoware.proj/install/nebula_ros/lib/nebula_ros/continental_ars548_ros_wrapper_node: symbol lookup error: /home/autoware/autoware.proj/install/nebula_hw_interfaces/lib/libnebula_hw_interfaces_continental.so: undefined symbol: _ZN6nebula7drivers18continental_ars54828ContinentalARS548HwInterface10print_infoENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE
[ERROR] [continental_ars548_ros_wrapper_node-34]: process has died [pid 1070495, exit code 127, cmd '/home/autoware/autoware.proj/install/nebula_ros/lib/nebula_ros/continental_ars548_ros_wrapper_node --ros-args -r __node:=nebula_continental_ars548 -r __ns:=/sensing/radar/front_center -p use_sim_time:=False -p wheel_radius:=0.3725 -p wheel_width:=0.215 -p wheel_base:=4.76012 -p wheel_tread:=1.754 -p front_overhang:=0.95099 -p rear_overhang:=1.52579 -p left_overhang:=0.26878 -p right_overhang:=0.26878 -p vehicle_height:=3.08 -p max_steer_angle:=0.64 --params-file /tmp/launch_params_yr_ptfd9 --params-file /tmp/launch_params_zukbcq0v --params-file /tmp/launch_params_gaqs682k --params-file /tmp/launch_params__f4mapei -r odometry_input:=/sensing/vehicle_velocity_converter/twist_with_covariance_throttled -r acceleration_input:=/localization/acceleration_throttled -r steering_angle_input:=/vehicle/status/steering_status_scalar_throttled -r diagnostics:=/diagnostics'].

I replaced the removed function with new nebula logger, and I confirmed the service call succeeded after this change with the actual sensor.

$ ros2 service call /sensing/radar/front_center/set_radar_parameters continental_srvs/srv/ContinentalArs548SetRadarParameters "{maximum_distance: 301, frequency_band: mid, cycle_time_ms: 100, time_slot_ms: 79, country_code: japan, powersave_standstill: 0}"
waiting for service to become available...
requester: making request: continental_srvs.srv.ContinentalArs548SetRadarParameters_Request(maximum_distance=301, frequency_band='mid', cycle_time_ms=100, time_slot_ms=79, country_code='japan', powersave_standstill=0)

response:
continental_srvs.srv.ContinentalArs548SetRadarParameters_Response(success=True, message='OK')

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@TomohitoAndo TomohitoAndo requested a review from mojomex May 15, 2025 11:44
@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 31.69%. Comparing base (b1539d8) to head (2cdf571).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
- Coverage   32.77%   31.69%   -1.09%     
==========================================
  Files         112      111       -1     
  Lines        9729     9743      +14     
  Branches     5017     4156     -861     
==========================================
- Hits         3189     3088     -101     
- Misses       5941     6099     +158     
+ Partials      599      556      -43     
Flag Coverage Δ
differential 31.69% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Common 42.45% <ø> (-11.91%) ⬇️
Hesai 29.22% <ø> (-1.05%) ⬇️
Velodyne 40.08% <ø> (-0.01%) ⬇️
Continental 31.82% <0.00%> (+0.70%) ⬆️
Robosense 5.64% <ø> (-0.10%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(sorry, think we had done this before)

@mojomex mojomex merged commit 707f29a into tier4:main May 16, 2025
13 of 19 checks passed
mojomex pushed a commit that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants