fix: ars548: replace removed logger with nebula logger#321
Merged
mojomex merged 1 commit intotier4:mainfrom May 16, 2025
Merged
fix: ars548: replace removed logger with nebula logger#321mojomex merged 1 commit intotier4:mainfrom
mojomex merged 1 commit intotier4:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
==========================================
- Coverage 32.77% 31.69% -1.09%
==========================================
Files 112 111 -1
Lines 9729 9743 +14
Branches 5017 4156 -861
==========================================
- Hits 3189 3088 -101
- Misses 5941 6099 +158
+ Partials 599 556 -43
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
knzo25
approved these changes
May 15, 2025
Contributor
knzo25
left a comment
There was a problem hiding this comment.
LGTM
(sorry, think we had done this before)
mojomex
pushed a commit
that referenced
this pull request
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
Description
The Nebula node crashes with an
undefined symbolerror when calling the service for the ARS548, because it references a logging function that was previously removed.The function was removed here.
I replaced the removed function with new nebula logger, and I confirmed the service call succeeded after this change with the actual sensor.
Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks